Merge pull request #26 from bknd-io/fix/mm-sync

fix: only sync config table once certain it has to happen

app/src/core/utils/test.ts

@@ -5,10 +5,21 @@ const _oldConsoles = {
    error: console.error
 };
 
+export async function withDisabledConsole<R>(
+   fn: () => Promise<R>,
+   severities: ConsoleSeverity[] = ["log"]
+): Promise<R> {
+   const enable = disableConsoleLog(severities);
+   const result = await fn();
+   enable();
+   return result;
+}
+
 export function disableConsoleLog(severities: ConsoleSeverity[] = ["log"]) {
    severities.forEach((severity) => {
       console[severity] = () => null;
    });
+   return enableConsoleLog;
 }
 
 export function enableConsoleLog() {

app/src/data/entities/query/Repository.ts

@@ -201,7 +201,10 @@ export class Repository<DB = any, TB extends keyof DB = any> implements EmitsEve
             }
          };
       } catch (e) {
-         console.error("many error", e, compiled);
+         if (e instanceof Error) {
+            console.error("[ERROR] Repository.performQuery", e.message);
+         }
+
          throw e;
       }
    }

app/src/modules/ModuleManager.ts

@@ -7,9 +7,11 @@ import {
    type Static,
    StringEnum,
    Type,
+   mark,
    objectEach,
    stripMark,
-   transformObject
+   transformObject,
+   withDisabledConsole
 } from "core/utils";
 import {
    type Connection,
@@ -23,7 +25,7 @@ import {
 } from "data";
 import { TransformPersistFailedException } from "data/errors";
 import { Hono } from "hono";
-import { type Kysely, sql } from "kysely";
+import type { Kysely } from "kysely";
 import { mergeWith } from "lodash-es";
 import { CURRENT_VERSION, TABLE_NAME, migrate } from "modules/migrations";
 import { AppServer } from "modules/server/AppServer";
@@ -73,6 +75,7 @@ export type ModuleManagerOptions = {
    ) => Promise<void>;
    // base path for the hono instance
    basePath?: string;
+   trustFetched?: boolean;
 };
 
 type ConfigTable<Json = ModuleConfigs> = {
@@ -187,7 +190,10 @@ export class ModuleManager {
    }
 
    async syncConfigTable() {
-      return await this.__em.schema().sync({ force: true });
+      this.logger.context("sync").log("start");
+      const result = await this.__em.schema().sync({ force: true });
+      this.logger.log("done").clear();
+      return result;
    }
 
    private rebuildServer() {
@@ -226,19 +232,23 @@ export class ModuleManager {
    private async fetch(): Promise<ConfigTable> {
       this.logger.context("fetch").log("fetching");
 
-      const startTime = performance.now();
-      const { data: result } = await this.repo().findOne(
-         { type: "config" },
-         {
-            sort: { by: "version", dir: "desc" }
-         }
-      );
-      if (!result) {
-         throw BkndError.with("no config");
-      }
+      // disabling console log, because the table might not exist yet
+      return await withDisabledConsole(async () => {
+         const startTime = performance.now();
+         const { data: result } = await this.repo().findOne(
+            { type: "config" },
+            {
+               sort: { by: "version", dir: "desc" }
+            }
+         );
 
-      this.logger.log("took", performance.now() - startTime, "ms", result).clear();
-      return result as ConfigTable;
+         if (!result) {
+            throw BkndError.with("no config");
+         }
+
+         this.logger.log("took", performance.now() - startTime, "ms", result.version).clear();
+         return result as ConfigTable;
+      }, ["log", "error", "warn"]);
    }
 
    async save() {
@@ -359,9 +369,6 @@ export class ModuleManager {
          configs = _configs;
 
          this.setConfigs(configs);
-         /* objectEach(configs, (config, key) => {
-            this.get(key as any).setConfig(config);
-         }); */
 
          this._version = version;
          this.logger.log("migrated to", version);
@@ -395,10 +402,11 @@ export class ModuleManager {
          return;
       }
 
+      this.logger.log("building");
       const ctx = this.ctx(true);
       for (const key in this.modules) {
-         this.logger.log(`building "${key}"`);
          await this.modules[key].setContext(ctx).build();
+         this.logger.log("built", key);
       }
 
       this._built = true;
@@ -409,11 +417,6 @@ export class ModuleManager {
       this.logger.context("build").log("version", this.version());
       this.logger.log("booted with", this._booted_with);
 
-      // @todo: check this, because you could start without an initial config
-      if (this.version() !== CURRENT_VERSION) {
-         await this.syncConfigTable();
-      }
-
       // if no config provided, try fetch from db
       if (this.version() === 0) {
          this.logger.context("no version").log("version is 0");
@@ -422,6 +425,16 @@ export class ModuleManager {
 
             // set version and config from fetched
             this._version = result.version;
+
+            if (this.version() !== CURRENT_VERSION) {
+               await this.syncConfigTable();
+            }
+
+            if (this.options?.trustFetched === true) {
+               this.logger.log("trusting fetched config (mark)");
+               mark(result.json);
+            }
+
             this.setConfigs(result.json);
          } catch (e: any) {
             this.logger.clear(); // fetch couldn't clear
@@ -431,6 +444,7 @@ export class ModuleManager {
             // we can safely build modules, since config version is up to date
             // it's up to date because we use default configs (no fetch result)
             this._version = CURRENT_VERSION;
+            await this.syncConfigTable();
             await this.buildModules();
             await this.save();
 

app/src/ui/components/canvas/layouts/index.ts

@@ -25,12 +25,6 @@ export const layoutWithDagre = ({ nodes, edges, graph }: LayoutProps) => {
    const dagreGraph = new Dagre.graphlib.Graph();
    dagreGraph.setDefaultEdgeLabel(() => ({}));
    dagreGraph.setGraph(graph || {});
-   /*dagreGraph.setGraph({
-      rankdir: "LR",
-      align: "UR",
-      nodesep: NODE_SEP,
-      ranksep: RANK_SEP
-   });*/
 
    nodes.forEach((node) => {
       dagreGraph.setNode(node.id, {
@@ -48,7 +42,11 @@ export const layoutWithDagre = ({ nodes, edges, graph }: LayoutProps) => {
    return {
       nodes: nodes.map((node) => {
          const position = dagreGraph.node(node.id);
-         return { ...node, x: position.x, y: position.y };
+         return {
+            ...node,
+            x: position.x - (node.width ?? 0) / 2,
+            y: position.y - (node.height ?? 0) / 2
+         };
       }),
       edges
    };

app/src/ui/modules/data/components/canvas/DataSchemaCanvas.tsx

@@ -69,15 +69,13 @@ export function DataSchemaCanvas() {
    const nodeLayout = layoutWithDagre({
       nodes: nodes.map((n) => ({
          id: n.id,
-         ...EntityTableNode.getSize(n)
+         ...EntityTableNode.getSize(n.data)
       })),
       edges,
       graph: {
          rankdir: "LR",
-         //align: "UR",
-         ranker: "network-simplex",
-         nodesep: 350,
-         ranksep: 50
+         marginx: 50,
+         marginy: 50
       }
    });
 
@@ -88,12 +86,6 @@ export function DataSchemaCanvas() {
       }
    });
 
-   /*const _edges = edges.map((e) => ({
-      ...e,
-      source: e.source + `-${e.target}_id`,
-      target: e.target + "-id"
-   }));*/
-
    return (
       <ReactFlowProvider>
          <Canvas

app/src/ui/modules/data/components/schema/create-modal/step.entity.fields.tsx

@@ -1,6 +1,7 @@
 import { typeboxResolver } from "@hookform/resolvers/typebox";
+import type { Static } from "core/utils";
 import { type TAppDataEntityFields, entitiesSchema } from "data/data-schema";
-import { useRef, useState } from "react";
+import { useRef } from "react";
 import { useForm } from "react-hook-form";
 import { MantineSelect } from "ui/components/form/hook-form-mantine/MantineSelect";
 import { useEvent } from "ui/hooks/use-event";
@@ -11,31 +12,33 @@ import {
 import { ModalBody, ModalFooter, type TCreateModalSchema, useStepContext } from "./CreateModal";
 
 const schema = entitiesSchema;
+type Schema = Static<typeof schema>;
 
 export function StepEntityFields() {
    const { nextStep, stepBack, state, setState } = useStepContext<TCreateModalSchema>();
    const entity = state.entities?.create?.[0]!;
    const defaultFields = { id: { type: "primary", name: "id" } } as const;
    const ref = useRef<EntityFieldsFormRef>(null);
+   const initial = entity
+      ? entity
+      : {
+           fields: defaultFields,
+           config: {
+              sort_field: "id",
+              sort_dir: "asc"
+           }
+        };
    const {
       control,
       formState: { isValid, errors },
       getValues,
       handleSubmit,
       watch,
-      register,
       setValue
    } = useForm({
       mode: "onTouched",
       resolver: typeboxResolver(schema),
-      defaultValues: {
-         ...entity,
-         fields: defaultFields,
-         config: {
-            sort_field: "id",
-            sort_dir: "asc"
-         }
-      }
+      defaultValues: initial as NonNullable<Schema>
    });
 
    const values = watch();
@@ -74,7 +77,11 @@ export function StepEntityFields() {
                      Add fields to <strong>{entity.name}</strong>:
                   </p>
                   <div className="flex flex-col gap-1">
-                     <EntityFieldsForm ref={ref} fields={defaultFields} onChange={updateListener} />
+                     <EntityFieldsForm
+                        ref={ref}
+                        fields={initial.fields as any}
+                        onChange={updateListener}
+                     />
                   </div>
                </div>
                <div className="flex flex-col gap-3">
@@ -82,7 +89,7 @@ export function StepEntityFields() {
                   <div className="flex flex-row gap-2">
                      <MantineSelect
                         label="Field"
-                        data={Object.keys(values.fields).filter((name) => name.length > 0)}
+                        data={Object.keys(values.fields ?? {}).filter((name) => name.length > 0)}
                         placeholder="Select field"
                         name="config.sort_field"
                         allowDeselect={false}
@@ -102,7 +109,7 @@ export function StepEntityFields() {
                <div>
                   {Object.entries(errors).map(([key, value]) => (
                      <p key={key}>
-                        {key}: {value.message}
+                        {key}: {(value as any).message}
                      </p>
                   ))}
                </div>

app/src/ui/routes/data/forms/entity.fields.form.tsx

@@ -72,22 +72,16 @@ export const EntityFieldsForm = forwardRef<
       name,
       field
    }));
-   /*const entityFields = entity.fields.map((field) => ({
-         name: field.name,
-         field: field.toJSON()
-      }));*/
 
    const {
       control,
       formState: { isValid, errors },
       getValues,
-      handleSubmit,
       watch,
       register,
       setValue,
       setError,
-      reset,
-      clearErrors
+      reset
    } = useForm({
       mode: "all",
       resolver: typeboxResolver(schema),
@@ -114,7 +108,6 @@ export const EntityFieldsForm = forwardRef<
             props?.onChange?.(toCleanValues(data));
          });
       }
-      //props?.onChange?.()
    }, []);
 
    useImperativeHandle(ref, () => ({
@@ -122,25 +115,9 @@ export const EntityFieldsForm = forwardRef<
       getValues: () => getValues(),
       getData: () => {
          return toCleanValues(getValues());
-         /*return Object.fromEntries(
-            getValues().fields.map((field) => [field.name, objectCleanEmpty(field.field)])
-         );*/
       },
       isValid: () => isValid
    }));
-   console.log("errors", errors.fields);
-
-   /*useEffect(() => {
-      console.log("change", values);
-      onSubmit(values);
-   }, [values]);*/
-
-   function onSubmit(data: TFieldsFormSchema) {
-      console.log("submit", isValid, data, errors);
-   }
-   function onSubmitInvalid(a, b) {
-      console.log("submit invalid", a, b);
-   }
 
    function handleAppend(_type: keyof typeof fieldsSchemaObject) {
       const newField = {
@@ -151,7 +128,6 @@ export const EntityFieldsForm = forwardRef<
             config: {}
          }
       };
-      console.log("handleAppend", _type, newField);
       append(newField);
    }
 
@@ -165,10 +141,7 @@ export const EntityFieldsForm = forwardRef<
    };
    return (
       <>
-         <form
-            onSubmit={handleSubmit(onSubmit as any, onSubmitInvalid)}
-            className="flex flex-col gap-6"
-         >
+         <div className="flex flex-col gap-6">
             <div className="flex flex-col gap-3">
                <div className="flex flex-col gap-4">
                   {sortable ? (
@@ -220,9 +193,7 @@ export const EntityFieldsForm = forwardRef<
                   </Popover>
                </div>
             </div>
-            <button type="submit" className="hidden" />
-            {/*<Debug watch={watch} errors={errors} />*/}
-         </form>
+         </div>
       </>
    );
 });