shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent/reaper): skip reaper tests in CI (#23068)

Browse Source 
ForkReap's syscall.ForkExec and process-directed signals remain
flaky in CI despite the subprocess isolation added in #22894.
Restore the testutil.InCI() skip guard that was removed in that
change.

Fixes coder/internal#1402
This commit is contained in:
Mathias Fredriksson
2026-03-14 22:15:47 +02:00
committed by GitHub
parent 266c611716
commit 1adc22fffd
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agent/reaper/reaper_test.go
+9
View File
@@ -78,6 +78,9 @@ func withDone(t *testing.T) []reaper.Option {
// processes and passes their PIDs through the shared channel.
func TestReap(t *testing.T) {
t.Parallel()
if testutil.InCI() {
t.Skip("Detected CI, skipping reaper tests")
}
if !runSubprocess(t) {
return
}
@@ -124,6 +127,9 @@ func TestReap(t *testing.T) {
//nolint:tparallel // Subtests must be sequential, each starts its own reaper.
func TestForkReapExitCodes(t *testing.T) {
t.Parallel()
if testutil.InCI() {
t.Skip("Detected CI, skipping reaper tests")
}
if !runSubprocess(t) {
return
}
@@ -164,6 +170,9 @@ func TestForkReapExitCodes(t *testing.T) {
// ensures SIGINT cannot kill the parent test binary.
func TestReapInterrupt(t *testing.T) {
t.Parallel()
if testutil.InCI() {
t.Skip("Detected CI, skipping reaper tests")
}
if !runSubprocess(t) {
return
}