mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
fix(coderd): remove false devcontainers early access warning (#23056)
The script source claimed Dev Containers are early access and told users to set CODER_AGENT_DEVCONTAINERS_ENABLE=true, which already defaults to true. Clear the script source and set RunOnStart to false since there is nothing to run.
This commit is contained in:
committed by
GitHub
parent
9c2f217ca2
commit
703b974757
@@ -2982,14 +2982,11 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
|
||||
scriptsParams.ScriptIDs = append(scriptsParams.ScriptIDs, id) // Re-use the devcontainer ID as the script ID for identification.
|
||||
scriptsParams.ScriptDisplayNames = append(scriptsParams.ScriptDisplayNames, displayName)
|
||||
scriptsParams.ScriptLogPaths = append(scriptsParams.ScriptLogPaths, "")
|
||||
scriptsParams.ScriptSources = append(scriptsParams.ScriptSources, `echo "WARNING: Dev Containers are early access. If you're seeing this message then Dev Containers haven't been enabled for your workspace yet. To enable, the agent needs to run with the environment variable CODER_AGENT_DEVCONTAINERS_ENABLE=true set."`)
|
||||
scriptsParams.ScriptSources = append(scriptsParams.ScriptSources, "")
|
||||
scriptsParams.ScriptCron = append(scriptsParams.ScriptCron, "")
|
||||
scriptsParams.ScriptTimeout = append(scriptsParams.ScriptTimeout, 0)
|
||||
scriptsParams.ScriptStartBlocksLogin = append(scriptsParams.ScriptStartBlocksLogin, false)
|
||||
// Run on start to surface the warning message in case the
|
||||
// terraform resource is used, but the experiment hasn't
|
||||
// been enabled.
|
||||
scriptsParams.ScriptRunOnStart = append(scriptsParams.ScriptRunOnStart, true)
|
||||
scriptsParams.ScriptRunOnStart = append(scriptsParams.ScriptRunOnStart, false)
|
||||
scriptsParams.ScriptRunOnStop = append(scriptsParams.ScriptRunOnStop, false)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user