shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(coderd/x/chatd): simplify quickgen prompt assertions

Browse Source
This commit is contained in:
Michael Suchacz
2026-05-28 10:43:14 +00:00
parent ee99d7622c
commit c1aeb67430
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/x/chatd/quickgen_internal_test.go
+4 -6
View File
@@ -688,7 +688,7 @@ func TestGenerateStructuredTitleWithUsage_OpenAICompatibleRequiredToolChoice(t *
body := testutil.TryReceive(t.Context(), t, requests)
require.Equal(t, "required", body["tool_choice"])
requireOpenAICompatLastMessageRole(t, body, "assistant")
requireOpenAICompatAssistantFinalMessage(t, body)
}
func newOpenAICompatStructuredOutputServer(
@@ -773,7 +773,6 @@ func requireSyntheticQuickgenPrompt(t *testing.T, prompt fantasy.Prompt, userInp
require.Equal(t, fantasy.MessageRoleSystem, prompt[0].Role)
require.Equal(t, fantasy.MessageRoleUser, prompt[1].Role)
require.Equal(t, fantasy.MessageRoleAssistant, prompt[2].Role)
require.NotEqual(t, fantasy.MessageRoleUser, prompt[len(prompt)-1].Role)
require.NotEmpty(t, prompt[1].Content)
require.NotEmpty(t, prompt[2].Content)
@@ -787,7 +786,7 @@ func requireSyntheticQuickgenPrompt(t *testing.T, prompt fantasy.Prompt, userInp
require.Equal(t, quickgenStructuredOutputReady, assistantText.Text)
}
func requireOpenAICompatLastMessageRole(t *testing.T, body map[string]any, want string) {
func requireOpenAICompatAssistantFinalMessage(t *testing.T, body map[string]any) {
t.Helper()
messages, ok := body["messages"].([]any)
@@ -796,8 +795,7 @@ func requireOpenAICompatLastMessageRole(t *testing.T, body map[string]any, want
lastMessage, ok := messages[len(messages)-1].(map[string]any)
require.True(t, ok)
require.Equal(t, want, lastMessage["role"])
require.NotEqual(t, "user", lastMessage["role"])
require.Equal(t, "assistant", lastMessage["role"])
}
func TestGenerateStructuredTurnStatusLabel(t *testing.T) {
@@ -834,7 +832,7 @@ func TestGenerateStructuredTurnStatusLabel(t *testing.T) {
body := testutil.TryReceive(t.Context(), t, requests)
require.Equal(t, "required", body["tool_choice"])
requireOpenAICompatLastMessageRole(t, body, "assistant")
requireOpenAICompatAssistantFinalMessage(t, body)
})
t.Run("rejects narrative label", func(t *testing.T) {