shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Makefile): run storybook tests after Go tests in pre-push (#24703)

Browse Source 
Rolldown's tokio workers stall when competing with Go compilation
and the production site build for CPU, causing Vite transform
requests to hang. Vitest browser mode has no import-phase timeout,
so a stalled browser import() blocks the run indefinitely.
This commit is contained in:
Mathias Fredriksson
2026-04-24 13:40:37 +03:00
committed by GitHub
parent 3d90546aae
commit ce125831d3
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Makefile
+8 -1
View File
@@ -881,8 +881,15 @@ pre-push:
$(MAKE) --no-print-directory -j$(PARALLEL_JOBS) MAKE_TIMED=1 MAKE_LOGDIR=$$logdir \ $(MAKE) --no-print-directory -j$(PARALLEL_JOBS) MAKE_TIMED=1 MAKE_LOGDIR=$$logdir \
test \ test \
test-js \ test-js \
test-storybook \
site/out/index.html site/out/index.html
# Storybook tests run after Go tests and the site build to avoid
# CPU starvation. Rolldown's tokio workers in Vite's transform
# pipeline stall when competing with Go compilation and the
# production build, causing browser import() calls to hang
# indefinitely (vitest has no import-phase timeout).
echo "test storybook:"
$(MAKE) --no-print-directory MAKE_TIMED=1 MAKE_LOGDIR=$$logdir \
test-storybook
rm -rf $$logdir rm -rf $$logdir
echo "$(GREEN)✓ pre-push passed$(RESET) ($$(( $$(date +%s) - $$start ))s)" echo "$(GREEN)✓ pre-push passed$(RESET) ($$(( $$(date +%s) - $$start ))s)"
.PHONY: pre-push .PHONY: pre-push