mirror of
https://github.com/coder/coder.git
synced 2026-06-04 13:38:21 +00:00
Kacper Sawicki
60e3ab7632
### Summary Workspace created via mode=auto links now require explicit user confirmation before provisioning. A warning dialog shows all prefilled param.* values from the URL and blocks creation until the user clicks `Confirm and Create`. Clicking `Cancel` falls back to the standard form view. <img width="820" height="475" alt="auto-create-consent-dialog" src="https://github.com/user-attachments/assets/8339e3bd-434f-4a04-9385-436bf95f49d7" /> ### Breaking behavior change Links using `mode=auto` (e.g., "Open in Coder" buttons) will no longer silently create workspaces. Users will now see a consent dialog and must explicitly confirm before the workspace is provisioned. Any existing integrations or automation relying on `mode=auto` for seamless workspace creation will now require manual user interaction. --------- Co-authored-by: Jake Howell <jacob@coder.com>
74 lines
2.2 KiB
TypeScript
74 lines
2.2 KiB
TypeScript
import { expect, test } from "@playwright/test";
|
|
import { users } from "../../constants";
|
|
import {
|
|
createTemplate,
|
|
createWorkspace,
|
|
echoResponsesWithParameters,
|
|
login,
|
|
} from "../../helpers";
|
|
import { beforeCoderTest } from "../../hooks";
|
|
import { emptyParameter } from "../../parameters";
|
|
import type { RichParameter } from "../../provisionerGenerated";
|
|
|
|
test.describe.configure({ mode: "parallel" });
|
|
|
|
let template!: string;
|
|
|
|
test.beforeAll(async ({ browser }) => {
|
|
const page = await (await browser.newContext()).newPage();
|
|
await login(page, users.templateAdmin);
|
|
|
|
const richParameters: RichParameter[] = [
|
|
{ ...emptyParameter, name: "repo", displayName: "Repo", type: "string" },
|
|
];
|
|
template = await createTemplate(
|
|
page,
|
|
echoResponsesWithParameters(richParameters),
|
|
);
|
|
});
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
beforeCoderTest(page);
|
|
await login(page, users.member);
|
|
});
|
|
|
|
test("create workspace in auto mode", async ({ page }) => {
|
|
const name = "test-workspace";
|
|
await page.goto(
|
|
`/templates/${template}/workspace?mode=auto¶m.repo=example&name=${name}`,
|
|
{
|
|
waitUntil: "domcontentloaded",
|
|
},
|
|
);
|
|
await page.getByRole("button", { name: /confirm and create/i }).click();
|
|
await expect(page).toHaveTitle(`${users.member.username}/${name} - Coder`);
|
|
});
|
|
|
|
test("use an existing workspace that matches the `match` parameter instead of creating a new one", async ({
|
|
page,
|
|
}) => {
|
|
const prevWorkspace = await createWorkspace(page, template);
|
|
await page.goto(
|
|
`/templates/${template}/workspace?mode=auto¶m.repo=example&name=new-name&match=name:${prevWorkspace}`,
|
|
{
|
|
waitUntil: "domcontentloaded",
|
|
},
|
|
);
|
|
await page.getByRole("button", { name: /confirm and create/i }).click();
|
|
await expect(page).toHaveTitle(
|
|
`${users.member.username}/${prevWorkspace} - Coder`,
|
|
);
|
|
});
|
|
|
|
test("show error if `match` parameter is invalid", async ({ page }) => {
|
|
const prevWorkspace = await createWorkspace(page, template);
|
|
await page.goto(
|
|
`/templates/${template}/workspace?mode=auto¶m.repo=example&name=new-name&match=not-valid-query:${prevWorkspace}`,
|
|
{
|
|
waitUntil: "domcontentloaded",
|
|
},
|
|
);
|
|
await page.getByRole("button", { name: /confirm and create/i }).click();
|
|
await expect(page.getByText("Invalid match value")).toBeVisible();
|
|
});
|