Cian Johnston da2fa082bb fix(coderd/httpapi): CloseRead on test conns to ensure pings pong (#25184) ...

The `websocketPair` test helper was not calling `CloseRead` on either
side of the connection. Without `CloseRead`, the websocket library does
not process control frames (ping/pong), so the heartbeat tests were
passing only because no pings had yet failed, not because pings were
actually succeeding.

Add `CloseRead` on both the client and server connections so that pong
frames are delivered in response to pings.

Split out from #25012.

> 🤖 Generated with [Coder Agents](https://coder.com)

2026-05-14 13:54:59 +01:00

..

httpapiconstraints

refactor(coderd/httpapi): remove database, dbauthz and rbac imports (#9481)

2023-09-04 19:39:14 +03:00

httperror

refactor: untangle workspace creation from http logic (#19639)

2025-08-29 14:17:33 +01:00

authz_slim.go

chore: avoid depending on rbac in slim builds (#17959)

2025-05-22 19:48:23 +10:00

authz.go

chore: bring back x-auth-checks with a length limit (#19928)

2025-09-24 10:46:50 -06:00

chatlabels_test.go

feat: add labels to chats (#23594)

2026-03-25 17:26:26 +00:00

chatlabels.go

feat: add labels to chats (#23594)

2026-03-25 17:26:26 +00:00

cookie_test.go

fix: use unique cookies for workspace proxies (#19930)

2025-09-25 00:30:02 +10:00

cookie.go

fix: use unique cookies for workspace proxies (#19930)

2025-09-25 00:30:02 +10:00

httpapi_test.go

fix(coderd/httpapi): stop writing websocket frames to ResponseRecorder in test (#25284)

2026-05-14 09:15:14 +01:00

httpapi.go

fix: prioritize context cancellation in WebSocket sendEvent (#23756)

2026-03-29 20:11:30 -04:00

json_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

json.go

chore: format Go more aggressively

2023-02-18 18:32:09 -06:00

noop.go

feat: remove site wide perms from creating a workspace (#17296)

2025-04-09 14:35:43 -05:00

queryparams_test.go

feat(coderd/httpapi): add QueryParamParser.JSONStringMap (#16578)

2025-02-18 14:14:30 +00:00

queryparams.go

fix(coderd): harden OAuth2 provider security (#22194)

2026-02-23 12:18:44 +01:00

request.go

feat: add panic recovery middleware (#3687)

2022-08-29 17:00:52 -05:00

websocket_internal_test.go

fix(coderd/httpapi): CloseRead on test conns to ensure pings pong (#25184)

2026-05-14 13:54:59 +01:00

websocket.go

fix(coderd): downgrade heartbeat ping errors for closed connections to debug (#23025)

2026-03-13 10:38:39 +00:00